Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #31 & #32: Change temperatures to PECI #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #31 & #32: Change temperatures to PECI #33

wants to merge 2 commits into from

Conversation

BourgonLaurent
Copy link

Issues related

#31 GPU Temperature is Broken
#32 CPU Temperature is taken from the Proximity Sensor

How it was fixed

Used the PECI values TCXC and TCGC, instead of CPU Proximity Sensor TC0P and GPU Proximity Sensor TG0P (broken when tested on MacBookPro16,2 running macOS Catalina 10.15.6).

How it changes the software

It seems like the PECI values are much more similar to the values of each core, without actually targeting one (the microcontroller takes care of this). After a bit of research, it seems like Intel Power Gadget and macOS are using this value to change their thermals.

Compatibility

Since PECI is available on all CPUs after the Intel Core 2 Duo, this will only work on devices whose processor was made after. Looking at the MacBook line-up, this means all MacBooks made after the MacBook2,1 Late 2006 should work.

@DrPsychick
Copy link

Tried several keys. (TC0P, TC0D, TG0P, TG0D, TCXC, TCGC).

For my MacBook Pro (17-inch, Late 2011), the TCXC did not return any result (0.0), so I went with TC0D to get the CPU die temperature.

For GPU, the TCGC worked fine and returned the highest temperature compared to TG0P and TG0D.

references:

@DrPsychick DrPsychick mentioned this pull request Aug 19, 2020
Open
@TurtleWilly
Copy link

I went with:

#define SMC_KEY_CPU_TEMP "TCXC"  
#define SMC_KEY_GPU_TEMP "TCGC"
#define SMC_KEY_AMBIENT_TEMP "TA0P"

"TC0D" didn't do much here.

Also the orig. ambient temperature (via TA0V) was way off. No idea what it measured. Showed some 20.something°C. Even my room is hotter right now with around 30°C. 😬 So I went with "TA0P".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BourgonLaurent @DrPsychick @TurtleWilly